ammachado commented on PR #23198:
URL: https://github.com/apache/camel/pull/23198#issuecomment-4447065198
**Update on review items and a latent issue surfaced by improved logging**
Pushed changes addressing the review:
- **FQCN `java.io.File`** (lines 92/100): already imported at line 19 and
used as simple `File`. No change needed.
- **"others" depth `*/*/*`**: already tightened to `{*,*/*}` to match
gulpfile. No change needed.
- **`PRUNED_DIRS` `.camel-jbang*`**: renamed to `PRUNED_DIR_PREFIXES`; now
matches exact name or `<name>-...` form, pruning `.camel-jbang-work` alongside
`.camel-jbang`, matching the original glob intent.
- **Flat `createNav` scan**: added a comment noting the flat scan is
equivalent to gulp's `**/*.adoc` because the prior symlink step flattens.
Additional improvements made while verifying parity:
- `createNav` now logs `→ generated <path>/nav.adoc with N entries` (gulp
logged this; the mojo was silent).
- `createSymlinks` / `createExampleSymlinks` deduplicate by destination path
and log `(from N sources)` when occurrences differ — exposing basename
collisions and duplicate `include::{examplesdir}` references that
previously inflated the counts.
**Latent issue surfaced (pre-existing on `main`, out of scope for this PR):**
The new logging revealed **4 basename collisions** in the dataformats group,
where the Jackson 3.x components (`camel-jackson3*`) ship doc/JSON files with
the same names as their Jackson 2.x counterparts
(`camel-jackson*`). The alphabetically-later Jackson 3 version overwrites
the Jackson 2 one in
`docs/components/modules/dataformats/{pages,examples/json}`:
| Filename | Jackson 2.x | Jackson 3.x |
|---|---|---|
| `jackson-dataformat.adoc` / `jackson.json` | `camel-jackson` |
`camel-jackson3` |
| `jacksonXml-dataformat.adoc` / `jacksonXml.json` | `camel-jacksonxml` |
`camel-jackson3xml` |
| `avroJackson-dataformat.adoc` / `avroJackson.json` | `camel-jackson-avro`
| `camel-jackson3-avro` |
| `protobufJackson-dataformat.adoc` / `protobufJackson.json` |
`camel-jackson-protobuf` | `camel-jackson3-protobuf` |
The effect is visible on the public dataformats index — the "JSON Jackson"
entry on https://camel.apache.org/components/next/dataformats/index.html
resolves to the Jackson 3 page rather than Jackson 2:
<img width="1376" height="865" alt="image"
src="https://github.com/user-attachments/assets/e7e17466-c586-4237-b836-28ad30ac7817";
/>
This collision exists on `main` with the gulp pipeline too; filesystem
snapshot diff between gulp's output on `main` and the new mojo's output remains
empty (1212 == 1212 entries).
**Verification:** `formatter:format`, `impsort:sort`, `mvn install
-Psourcecheck`, 12 unit tests, and `mvn -Pregen generate-resources` all pass.
Filesystem parity with gulp on `main` confirmed via
`tools/snapshot-doc-symlinks.sh`.
_Claude Code on behalf of Adriano Machado_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
