apupier commented on code in PR #23300:
URL: https://github.com/apache/camel/pull/23300#discussion_r3259883709
##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/consumer/KinesisResumeStrategyConfiguration.java:
##########
@@ -60,7 +60,9 @@ public KinesisResumeStrategyConfigurationBuilder
withResumeCache(ResumeCache<?>
@Override
public KinesisResumeStrategyConfiguration build() {
KinesisResumeStrategyConfiguration result = new
KinesisResumeStrategyConfiguration();
- result.setResumeCache(resumeCache);
+ if (resumeCache != null) {
+ result.setResumeCache(resumeCache);
+ }
Review Comment:
and when reading code, it is even making less sense to forbid to provide a
null value as the attribute in the class is marked as @Nullable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
