oscerd opened a new pull request, #23474:
URL: https://github.com/apache/camel/pull/23474
## Summary
Renames the `MiloConstants.HEADER_AWAIT` header string value from `await` —
which sits **outside** the `Camel` namespace and is therefore not filtered by
the default `HeaderFilterStrategy` — to `CamelMiloAwait`, following the
convention used across the rest of the Camel component catalog and matching
the
pattern established in CAMEL-23526 (`camel-cxf`), CAMEL-23522 (`camel-mail`),
CAMEL-23461 (`camel-aws-bedrock`), CAMEL-23532 (`camel-vertx-websocket` /
`camel-atmosphere-websocket` / `camel-iggy`), and CAMEL-23576 (`camel-jira`).
| Constant | Previous value | New value |
|----------|----------------|-----------|
| `MiloConstants.HEADER_AWAIT` | `await` | `CamelMiloAwait` |
`HEADER_AWAIT` controls whether `milo-client` writes are awaited. The Java
field name is unchanged so routes referencing the constant symbolically
continue to work; routes using the literal string value must be updated
(documented in the 4.21 upgrade guide).
## Already-compliant constants left unchanged
`MiloConstants.HEADER_NODE_IDS` was already `Camel`-prefixed
(`CamelMiloNodeIds`).
## Test changes
`WriteClientTest` and `CallClientTest` set the header by its literal value
`"await"`; both are updated to `"CamelMiloAwait"`.
## Generated artifacts
- `components/camel-milo/.../milo-client.json` + catalog mirror
- `dsl/camel-endpointdsl/.../MiloClientEndpointBuilderFactory.java` — DSL
header
accessor renamed (`await()` → `miloAwait()`)
## Backports
- `camel-4.18.x`: `camel-milo` exists with the same legacy value (`await`) —
backport applies and will be filed as a follow-up PR.
- `camel-4.14.x`: `camel-milo` does **not** exist on that branch (the
component
was removed and later reinstated) — no backport.
## Test plan
- [x] `mvn test` in `components/camel-milo` — 41 tests pass (1 skipped)
- [x] Module + catalog + endpointdsl built cleanly; only `camel-milo` regen
artifacts included
- [x] The two literal-header tests updated to the new value
- [x] Upgrade guide entry added under `=== camel-milo`
Tracker: CAMEL-23577
_Reported by Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
