rkdfx opened a new pull request, #23485:
URL: https://github.com/apache/camel/pull/23485
# Description
Adds a new consumer-side URI option `enableBatchIndexAcknowledgment` to the
`camel-pulsar`
component.
The Pulsar client's `ConsumerBuilder` supports
`enableBatchIndexAcknowledgment(boolean)` to allow each message in a batch
to be acknowledged
independently. With the option disabled (the Pulsar client default), a
single failed
acknowledgment causes the broker to redeliver the entire batch — including
messages that were
processed successfully. The component previously built the
`ConsumerBuilder` without invoking
this method and exposed no URI parameter to configure it.
This change:
- Adds the option as a `@UriParam(label = "consumer")` field on
`PulsarConfiguration` with
default `false` (matches the Pulsar client's own default — no behaviour
change for existing
routes).
- Wires it into `CommonCreationStrategyImpl` in the same shape as the
existing `readCompacted`
option (unconditional pass-through onto the `ConsumerBuilder`).
- Adds a default-value assertion to
`PulsarComponentTest.testPulsarEndpointDefaultConfiguration`
and a new URI-parsing test
`testPulsarEndpointEnableBatchIndexAcknowledgment`.
Enabling this option also requires the Pulsar broker to be configured with
`acknowledgmentAtBatchIndexLevelEnabled=true` for the per-message
acknowledgments to take
effect. This is documented in the option's description.
Resolves https://issues.apache.org/jira/browse/CAMEL-23443
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4
uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other
small items do not require a JIRA issue. In this case your pull request should
address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful
subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX]
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the
appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder
and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build
auto-formats your code. This will also be verified as part of the checks and
your PR may be rejected if if there are uncommited changes after running `mvn
clean install -DskipTests`.
You can learn more about the contribution guidelines at
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
