oscerd commented on PR #23522: URL: https://github.com/apache/camel/pull/23522#issuecomment-4544487609
## CI failure (`build (17, false)`) appears unrelated to this PR The `UndertowWsConsumerRouteTest.echo` failure in [run 26442254234](https://github.com/apache/camel/actions/runs/26442254234/job/77839436053) (3/3 surefire reruns, all `expected: <true> but was: <false>` at exactly 10.02 s — the `wsclient1.await(10)` timeout) does not appear to be caused by this PR's `WEBSOCKET_FILTER_STARTS_WITH` change. **Why the change is not in the failure path** - `UndertowConsumer.sendMessage` sets `CONNECTION_KEY` via `exchange.getIn().setHeader(...)` (direct `Message` API). - `UndertowProducer.processWebSocket` reads `CONNECTION_KEY` via `in.getHeader(...)` (direct `Message` API). - The peer match uses `peer.getAttribute(CONNECTION_KEY)` on the `WebSocketChannel`, not a wire header. None of these go through `HeaderFilterStrategy`, so adding `"websocket."` to `setIn/OutFilterStartsWith` cannot affect the `echo` flow at the transport boundary. **Likely root cause** The test was previously skipped on GitHub Actions via `@DisabledIfSystemProperty(named = "ci.env.name", matches = ".*", disabledReason = "Flaky on GitHub Actions")`. The annotation was removed by `685e1a4eca3` (CAMEL-22539, 2026-05-07) without other hardening of this specific test. This PR's CI run is among the first to actually exercise it on GHA, and the 10 s `await` timeout under a contended runner is the same failure shape that motivated the original disablement. **Local repro on `fix/CAMEL-23588`** Run against the PR branch with `-Dci.env.name=github.com -Dsurefire.rerunFailingTestsCount=2`: - 5/5 isolated `UndertowWsConsumerRouteTest#echo` runs PASS (~1.1 s each) - 3/3 full-class `UndertowWsConsumerRouteTest` runs PASS (~1.7 s each) Suggested follow-ups (independent of this PR): - Rerun the `build (17, false)` job to confirm the flake. - Open a CAMEL Jira against `camel-undertow` for follow-up to CAMEL-22539 — either Awaitility-harden the test for slow GHA runners or restore `@DisabledIfSystemProperty` until it can be properly stabilized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
