oscerd opened a new pull request, #23537:
URL: https://github.com/apache/camel/pull/23537
Backports #23454 to `camel-4.18.x`. (`camel-github2` does not exist on
`camel-4.14.x` so this is the only backport branch needed.)
Cherry-pick of merge commit `3e94c446807` with one adaptation: the original
PR's upgrade-guide entry was added to `camel-4x-upgrade-guide-4_21.adoc`,
which does not exist on the 4.18.x maintenance branch. Per the project's
backport policy the same content has been added to
`camel-4x-upgrade-guide-4_18.adoc` instead, with the closing NOTE reworded
because the deprecated `camel-github` predecessor was only removed on the
4.21 development branch — it remains present (as deprecated) on 4.18.x.
## Summary
Renames the producer-side Exchange header string values in `GitHub2Constants`
that were **not** in the `Camel` namespace to `CamelGitHub<Name>`:
| Constant | Previous value | New value |
|----------|----------------|-----------|
| `GitHub2Constants.GITHUB_PULLREQUEST` | `GitHubPullRequest` |
`CamelGitHubPullRequest` |
| `GitHub2Constants.GITHUB_INRESPONSETO` | `GitHubInResponseTo` |
`CamelGitHubInResponseTo` |
| `GitHub2Constants.GITHUB_PULLREQUEST_HEAD_COMMIT_SHA` |
`GitHubPullRequestHeadCommitSHA` | `CamelGitHubPullRequestHeadCommitSha` |
| `GitHub2Constants.GITHUB_ISSUE_TITLE` | `GitHubIssueTitle` |
`CamelGitHubIssueTitle` |
## Already-compliant constants left unchanged
The consumer-side `GITHUB_COMMIT_AUTHOR`, `GITHUB_COMMIT_COMMITTER`,
`GITHUB_COMMIT_SHA`, `GITHUB_COMMIT_URL`, `GITHUB_EVENT_PAYLOAD` were already
`Camel`-prefixed; `GITHUB_CLIENT` (`github2Client`) is a registry-lookup key.
DSL accessor: `gitHubPullRequestHeadCommitSHA()` →
`gitHubPullRequestHeadCommitSha()`
(SHA acronym casing); other accessors keep names but return the new values.
## Test plan
- [x] `mvn test` in `components/camel-github2` on 4.18.x — 6 tests pass
- [x] Cherry-pick applied cleanly except for the 4_21 → 4_18 guide-file
rename described above (no merge marker shipped)
- [x] Upgrade-guide entry added under
`=== camel-github2 - potential breaking change` in
`camel-4x-upgrade-guide-4_18.adoc`, before the existing camel-web3j
entry
Tracker: CAMEL-23577
_Reported by Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
