davsclaus commented on code in PR #23568:
URL: https://github.com/apache/camel/pull/23568#discussion_r3312023315
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ExportQuarkus.java:
##########
@@ -318,16 +318,13 @@ protected String applicationPropertyLine(String key,
String value) {
@Override
protected void copyDockerFiles(String buildDir) throws Exception {
Path dockerSrc = Path.of(buildDir).resolve("src/main/docker");
- if ("uber-jar".equals(quarkusPackageType)) {
- // For uber-jar, the generic Dockerfile works as-is
- super.copyDockerFiles(buildDir);
- } else {
- // For fast-jar, use a Quarkus-specific JVM Dockerfile
- Files.createDirectories(dockerSrc);
- InputStream is
- =
ExportQuarkus.class.getClassLoader().getResourceAsStream("quarkus-docker/Dockerfile.jvm");
+ Files.createDirectories(dockerSrc);
+
+ // Use Quarkus-specific layered Dockerfile (fast-jar)
Review Comment:
Minor consistency concern: the uber-jar branch is removed here, but
`quarkusPackageType` is still used at line 150 (to select the `appJar` path)
and line 386 (passed to the POM template as `QuarkusPackageType`). If someone
passes `--quarkus-package-type uber-jar` (deprecated but accepted), Quarkus
will produce an uber-jar but this Dockerfile will expect fast-jar layout.
Since the option is deprecated and hidden, this is a low-risk edge case —
but worth considering a warning or removing the remaining uber-jar references
entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
