davsclaus commented on code in PR #23684: URL: https://github.com/apache/camel/pull/23684#discussion_r3338928757
########## test-infra/camel-test-infra-jaeger/src/main/resources/org/apache/camel/test/infra/jaeger/services/container.properties: ########## @@ -0,0 +1,19 @@ +## --------------------------------------------------------------------------- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --------------------------------------------------------------------------- +jaeger.container=quay.io/repository/jaegertracing/jaeger:2.18.0 Review Comment: The `/repository/` segment is part of the quay.io **web UI URL**, not a valid Docker image reference. No other test-infra module uses this pattern — all use `quay.io/<namespace>/<image>` directly (e.g., `quay.io/artemiscloud/activemq-artemis-broker`, `quay.io/infinispan/server`). This will cause a container pull failure at runtime. ```suggestion jaeger.container=quay.io/jaegertracing/jaeger:2.18.0 ``` ########## test-infra/camel-test-infra-jaeger/src/main/java/org/apache/camel/test/infra/jaeger/services/JaegerContainer.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.test.infra.jaeger.services; + +import org.apache.camel.test.infra.common.LocalPropertyResolver; +import org.apache.camel.test.infra.jaeger.common.JaegerProperties; +import org.testcontainers.containers.GenericContainer; +import org.testcontainers.containers.wait.strategy.Wait; +import org.testcontainers.utility.DockerImageName; + +public class JaegerContainer extends GenericContainer<JaegerContainer> { + public static final String CONTAINER_NAME = "jaeger"; + + public JaegerContainer() { + super(LocalPropertyResolver.getProperty(JaegerLocalContainerInfraService.class, JaegerProperties.JAEGER_CONTAINER)); + + this.withNetworkAliases(CONTAINER_NAME) + .withExposedPorts( + JaegerProperties.DEFAULT_COLLECTOR_GRPC_PORT, + JaegerProperties.DEFAULT_COLLECTOR_HTTP_PORT, + JaegerProperties.DEFAULT_QUERY_UI_PORT) + .waitingFor(Wait.forHttp("/").forPort(JaegerProperties.DEFAULT_QUERY_UI_PORT)); + } + + public JaegerContainer(String imageName) { + super(DockerImageName.parse(imageName)); Review Comment: Minor: this constructor only calls `super(DockerImageName.parse(imageName))` without configuring exposed ports, wait strategy, or network alias — unlike the no-arg constructor and the `initContainer()` factory method which both set these up. In practice this is OK because `JaegerLocalContainerInfraService(String)` uses `initContainer()`, but the public constructor is misleading if someone tries to use it directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
