apupier commented on code in PR #23713:
URL: https://github.com/apache/camel/pull/23713#discussion_r3343929050
##########
core/camel-core/src/test/java/org/apache/camel/builder/RouteTemplateLocalBeanTest.java:
##########
@@ -949,4 +949,36 @@ public static Processor createBuilderProcessorThree(String
prefix) {
return answer;
}
+ @Test
+ public void testLocalBeanWithParamValueClash() throws Exception {
+ context.addRoutes(new RouteBuilder() {
+ @Override
+ public void configure() {
+ routeTemplate("myTemplate")
+ .templateParameter("foo")
+ .templateParameter("scheme")
+
.templateBean("counter").typeClass(AtomicInteger.class).end()
+ .from("direct:{{foo}}")
+ .to("bean:{{counter}}?method=getAndIncrement");
+ }
+ });
+
+ context.start();
+
+ TemplatedRouteBuilder.builder(context, "myTemplate")
+ .parameter("foo", "one")
+ .parameter("scheme", "counter")
+ .routeId("myRoute")
+ .add();
+
+ assertEquals(1, context.getRoutes().size());
+
+ Object out = template.requestBody("direct:one", "World");
+ assertEquals(0, out);
Review Comment:
to ease readability, it would be nice to add a message for assertion
explaining why it expects 0
##########
core/camel-core/src/test/java/org/apache/camel/builder/RouteTemplateLocalBeanTest.java:
##########
@@ -949,4 +949,36 @@ public static Processor createBuilderProcessorThree(String
prefix) {
return answer;
}
+ @Test
+ public void testLocalBeanWithParamValueClash() throws Exception {
+ context.addRoutes(new RouteBuilder() {
+ @Override
+ public void configure() {
+ routeTemplate("myTemplate")
+ .templateParameter("foo")
+ .templateParameter("scheme")
+
.templateBean("counter").typeClass(AtomicInteger.class).end()
+ .from("direct:{{foo}}")
+ .to("bean:{{counter}}?method=getAndIncrement");
+ }
+ });
+
+ context.start();
+
+ TemplatedRouteBuilder.builder(context, "myTemplate")
+ .parameter("foo", "one")
+ .parameter("scheme", "counter")
+ .routeId("myRoute")
+ .add();
+
+ assertEquals(1, context.getRoutes().size());
+
+ Object out = template.requestBody("direct:one", "World");
+ assertEquals(0, out);
+ out = template.requestBody("direct:one", "World");
+ assertEquals(1, out);
Review Comment:
to ease readability, it would be nice to add a message for assertion
explaining why it expects 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
