davsclaus commented on code in PR #23863:
URL: https://github.com/apache/camel/pull/23863#discussion_r3374666772
##########
components/camel-redis/src/main/java/org/apache/camel/component/redis/processor/aggregate/RedisAggregationRepository.java:
##########
@@ -142,10 +148,10 @@ public Exchange add(CamelContext camelContext, String
key, Exchange exchange) {
throw new UnsupportedOperationException();
}
LOG.trace("Adding an Exchange with ID {} for key {} in a thread-safe
manner.", exchange.getExchangeId(), key);
- RLock lock = redisson.getLock("aggregationLock");
+ DefaultExchangeHolder newHolder =
DefaultExchangeHolder.marshal(exchange, true, allowSerializedHeaders);
Review Comment:
The per-key lock naming (`mapName + "-lock-" + key`) is a behavioral change
from the previous global `"aggregationLock"`. Existing deployments will see
different Redis lock keys after upgrading. Please add an upgrade guide entry in
`docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_21.adoc`
documenting this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
