thedavidweng commented on PR #6667: URL: https://github.com/apache/camel-k/pull/6667#issuecomment-4653799496
> Thanks for the PR. However this is completely wrong. Please, make sure to understand the entire logic before applying this again. In theory we should only skip the defaults values not recording them in the API trait type. Yeah sorry you're right, my bad for blindly trusting Codex too much. Now after examining again, I see two ways to implement. A, compare each executed trait against its default baseline and drop fields equal to the default in executedTraitCondition, before writing them into Status.Traits. B, carry the auto-inferred state in unexported fields/locals so the exported fields stay nil unless the user set them. I think option B would be a more thorough approach, but it involves wider changes. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
