davsclaus commented on PR #23868: URL: https://github.com/apache/camel/pull/23868#issuecomment-4659682087
### Addressing review feedback **Re: automated tests (#1)** — Added `OtlpProtobufSpanDataTest` with 10 test cases covering: basic span parsing, scope info extraction (Camel vs 3rd-party), attribute types (string/long/double/boolean), all span kind mappings, error status with description, root spans (no parent), multiple spans in a single request, resource attributes, and SpanData default values. **Re: duplicated deferred launch logic (#2)** — Refactored `startMissingInfraAndDeferExample()` and `startMissingInfraAndDeferFolder()` into a single `startMissingInfraAndDefer()` method with a `Runnable` callback. The two record types (`DeferredExampleLaunch`, `DeferredFolderLaunch`) are now unified into `DeferredLaunch`, and `checkDeferredLaunch()` is reduced to a single if-block. **Re: upgrade guide (#4)** — Added a new section documenting `exportTarget`, `--open-telemetry-agent`, `--open-telemetry-agent-export`, and the provided-scope proto dependency. **Re: camel-core-model dependency (#3)** — Acceptable coupling; dev-only path gated behind `isDevConsoleEnabled()` + agent detection. See inline reply. **Re: GlobalOpenTelemetry.set(devSdk) (#5)** — Intentional. The dev SDK needs global visibility for the `--observe` (non-agent) path. In the agent path, the agent installs its own GlobalOpenTelemetry, so this line is a no-op there. _Claude Code on behalf of Claus Ibsen_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
