ammachado commented on code in PR #23927:
URL: https://github.com/apache/camel/pull/23927#discussion_r3396976260
##########
core/camel-core/src/test/java/org/apache/camel/processor/DefaultConsumerBridgeErrorHandlerContinuedTest.java:
##########
@@ -48,10 +48,9 @@ public void testDefaultConsumerBridgeErrorHandlerContinued()
throws Exception {
getMockEndpoint("mock:onException").expectedMinimumMessageCount(1);
getMockEndpoint("mock:subroute").expectedMinimumMessageCount(1);
- // With continued(true), processing should continue after error
handling
- // However, since the consumer throws before creating a valid exchange,
- // mock:result won't receive messages
- getMockEndpoint("mock:result").expectedMessageCount(0);
+ // With continued(true), the exchange continues through the main route
after error handling,
+ // so mock:result should receive messages.
+ getMockEndpoint("mock:result").expectedMinimumMessageCount(1);
Review Comment:
@gnodet, you added this test in `CAMEL-22907` with `expectedMessageCount(0)`
and the comment "since the consumer throws before creating a valid exchange,
mock:result won't receive messages".
We found it flaky: after the `CAMEL-22907` fix, `continued(true)` causes the
exchange to continue through the main route after `onException` handling, so
`mock:result` does receive messages. The assertion was changed to
`expectedMinimumMessageCount(1)`.
Could you confirm whether this matches the intended post-fix behavior, or
whether `mock:result` was expected to remain at zero for a reason we may have
missed?
_Claude Code on behalf of Adriano Machado_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
