davsclaus commented on code in PR #24031:
URL: https://github.com/apache/camel/pull/24031#discussion_r3416469044
##########
core/camel-core-model/src/main/java/org/apache/camel/model/ToDefinition.java:
##########
@@ -40,6 +41,7 @@ public class ToDefinition extends
SendDefinition<ToDefinition> {
private String variableReceive;
@XmlAttribute
@Metadata(label = "advanced", javaType =
"org.apache.camel.ExchangePattern", enums = "InOnly,InOut")
+ @DslArg(position = 1, renderType = "enumString", typeName =
"ExchangePattern")
Review Comment:
Fixed in 6991fa5 — swapped positions: `pattern` → position 0, `uri` →
position 1. Now generates `.to(ExchangePattern.InOut, "mock:result")` matching
`ProcessorDefinition.to(ExchangePattern, String)`. Added `toWithPattern.xml`
test to cover this case (97/97 tests pass).
_Claude Code on behalf of Claus Ibsen_
##########
core/camel-core-model/src/main/java/org/apache/camel/model/SendDefinition.java:
##########
@@ -42,6 +43,7 @@ public abstract class SendDefinition<Type extends
ProcessorDefinition<Type>> ext
@XmlAttribute
@Metadata(required = true)
+ @DslArg
Review Comment:
Fixed in the same commit (6991fa5) — `SendDefinition.uri` is now
`@DslArg(position = 1)` so subclasses like `ToDefinition` that add a position-0
arg (pattern) get the correct ordering.
_Claude Code on behalf of Claus Ibsen_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
