luigidemasi commented on PR #24116:
URL: https://github.com/apache/camel/pull/24116#issuecomment-4751490639
@gnodet:
> Q1. The 22 Simple language functions added in SimpleConstants.java — are
they all covered by CAMEL-23776, or do some come from a separate ticket? The
JIRA says "Existing ${a2a:emit(...)} support remains available and unchanged",
implying a2a:emit predates this PR. Was there a prior implementation that
didn't use SimpleConstants?
Yes, `a2a:emit` and the other A2A Simple function implementations predate
this PR; they were added with CAMEL-23063. This PR only adds the
`SimpleConstants` metadata and generated catalog/prefix exposure for those
existing functions.
I included that here because CAMEL-23776 uses simple expressions for the
`a2aSubTask` emit fields, and the JIRA discussion called out that the A2A
Simple functions should be documented through `SimpleConstants`.
> Q2. The A2AConsumer changes (early task creation, failure status update,
cleanup) — are these prerequisites for a2aSubTask to work correctly via HTTP
(i.e., the consumer must create the task before the route runs so
hasTaskContext returns true)? If so, the coupling is justified but worth
documenting.
Yes, these are prerequisites for `a2aSubTask` to work correctly through
synchronous HTTP handling. Strict mode checks `A2AProgress.hasTaskContext()`,
and that check requires the submitted task to already exist in the task store
before route processing starts.
The failure update and cleanup are paired with that earlier task creation so
the task store does not retain an inconsistent submitted task when the route
fails or returns a non-task response.
_Claude Code on behalf of Luigi De Masi_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
