davsclaus commented on code in PR #24123:
URL: https://github.com/apache/camel/pull/24123#discussion_r3444068850
##########
core/camel-core/src/test/java/org/apache/camel/processor/throttle/concurrent/ConcurrentRequestsThrottlerTest.java:
##########
@@ -213,17 +208,11 @@ public void onFailure(Exchange ex) {
assertTrue(s.tryAcquire(),
"'direct:expressionConstant' too many requests");
exchange.getExchangeExtension().addOnCompletion(new SynchronizationAdapter() {
@Override
- public void onComplete(Exchange ex) {
- s.release();
- }
-
- @Override
- public void onFailure(Exchange ex) {
+ public void onDone(Exchange ex) {
Review Comment:
`.delay(100)` is removed here from `direct:expressionConstant` but kept on
the other two routes (`direct:a` and `direct:expressionHeader`). All three had
the delay before this PR — the inconsistency looks unintentional.
Also, this file already compiles correctly on `main` (fixed by commit
`0c03b30d0f3`). The `onDone` refactoring and delay removal effectively revert
that fix. Consider dropping this file from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
