gnodet commented on code in PR #24195: URL: https://github.com/apache/camel/pull/24195#discussion_r3458832669
########## components/camel-jackson-avro/src/test/java/org/apache/camel/component/jackson/avro/JacksonAvroDataFormatPolymorphicHardeningTest.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.jackson.avro; + +import com.fasterxml.jackson.databind.MapperFeature; +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.camel.impl.DefaultCamelContext; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * Verifies that the AvroMapper created by {@link JacksonAvroDataFormat} enables + * {@link MapperFeature#BLOCK_UNSAFE_POLYMORPHIC_BASE_TYPES} by default — the Jackson mechanism that refuses unsafe + * polymorphic base types (e.g. Object/Serializable) when polymorphic/default typing is enabled, as defense-in-depth + * against gadget-chain deserialization. + */ +public class JacksonAvroDataFormatPolymorphicHardeningTest { + + @Test + void blockUnsafePolymorphicBaseTypesEnabledByDefault() throws Exception { + try (DefaultCamelContext context = new DefaultCamelContext()) { + context.start(); + JacksonAvroDataFormat df = new JacksonAvroDataFormat(); + df.setCamelContext(context); Review Comment: Nit: the sibling test in PR #24134 (camel-jackson) calls `df.setUseDefaultObjectMapper(false)` before `df.start()` to guarantee that `createNewObjectMapper()` is exercised rather than picking up a mapper from the registry. This test relies on the `DefaultCamelContext` having no `ObjectMapper` registered, which is true today but fragile. Consider adding `df.setUseDefaultObjectMapper(false)` for consistency with the sibling. _Claude Code on behalf of Guillaume Nodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
