k-krawczyk commented on code in PR #24235:
URL: https://github.com/apache/camel/pull/24235#discussion_r3468813420
##########
dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/ActionsPopup.java:
##########
@@ -767,16 +767,19 @@ private void renderActionsMenu(Frame frame, Rect area) {
frame.renderWidget(Clear.INSTANCE, popup);
String divider = " ─────────────────────────────────";
- // extra space after ⌨️ because it renders narrower than other emoji
+ // CAMEL-23818: use unambiguous 2-wide emoji for these three labels.
The text-default
+ // base glyphs U+2328/U+23F9/U+23FA + VS16 (U+FE0F) render 2-wide but
TamboUI measures
+ // them as 1-wide, drifting the buffer and leaving stray characters
when scrolling.
+ // Revert once a TamboUI release with
https://github.com/tamboui/tamboui/pull/388 is adopted.
String keystrokeLabel = keystrokesEnabled.get()
- ? " ⌨️ Hide Keystrokes"
- : " ⌨️ Show Keystrokes";
+ ? " 🔤 Hide Keystrokes"
+ : " 🔤 Show Keystrokes";
String stopLabel = stopAllPopup.hasBothGroups()
? " 🛑 Stop All..."
: " 🛑 Stop All";
String tapeLabel = tapeRecordingActive.get()
- ? " ⏹️ Stop Tape Recording (Ctrl+R)"
- : " ⏺️ Start Tape Recording (Ctrl+R)";
+ ? " ⬛ Stop Tape Recording (Ctrl+R)"
Review Comment:
Good catch — switched the stop icon to 🛑 (same as the "Stop All" menu item),
per @davsclaus. It's a 2-wide emoji (verified against TamboUI's
`CharWidth.of`), so the buffer stays aligned and it's clearly visible on dark
terminals unlike the black square.
_Reported by Claude Code on behalf of Karol Krawczyk_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
