davsclaus commented on code in PR #24277: URL: https://github.com/apache/camel/pull/24277#discussion_r3486624342
########## dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/CamelMonitorTest.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.dsl.jbang.core.commands.tui; + +import dev.tamboui.tui.event.KeyCode; +import dev.tamboui.tui.event.KeyEvent; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +class CamelMonitorTest { + + // '?' is an alternative to F1 for opening the help overlay (CAMEL-23838). Unlike F1, it must be + // suppressed while a text input is focused, otherwise typing '?' in a search or probe field would + // pop up help instead of inserting the character. + + @Test Review Comment: Nit: the ticket reference `(CAMEL-23838)` in this comment will rot over time — the constraint (why `?` differs from F1) is worth documenting, but the ticket number belongs in the commit message / PR description rather than in code. ```suggestion // suppressed while a text input is focused, otherwise typing '?' in a search or probe field would // pop up help instead of inserting the character. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
