(camel-quarkus) branch main updated: Fix incremental build not testing Dependabot PRs

[jamesnetherton]

This is an automated email from the ASF dual-hosted git repository.

jamesnetherton pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-quarkus.git


The following commit(s) were added to refs/heads/main by this push:
     new 43bf273b7f Fix incremental build not testing Dependabot PRs
43bf273b7f is described below

commit 43bf273b7fd8a5611214004d9f55c6d4245b67ff
Author: James Netherton <jamesnether...@users.noreply.github.com>
AuthorDate: Mon Jun 29 09:37:16 2026 +0100

    Fix incremental build not testing Dependabot PRs
    
    Add TRANSITIVE to accepted Scalpel categories so that dependency version
    bumps through the BOM chain correctly identify affected test modules.
    
    Also fall back to a full build when a BOM module is directly affected but
    no test modules were identified, covering cases like bom-test dependency
    bumps where no regenerated files exist for Scalpel to trace.
    
    Co-authored-by: Claude Opus 4.6 <nore...@anthropic.com>
---
 .../camel/quarkus/maven/IncrementalBuildMojo.java  | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git 
a/tooling/maven-plugin/src/main/java/org/apache/camel/quarkus/maven/IncrementalBuildMojo.java
 
b/tooling/maven-plugin/src/main/java/org/apache/camel/quarkus/maven/IncrementalBuildMojo.java
index ae1d58a6a2..5977ea46d6 100644
--- 
a/tooling/maven-plugin/src/main/java/org/apache/camel/quarkus/maven/IncrementalBuildMojo.java
+++ 
b/tooling/maven-plugin/src/main/java/org/apache/camel/quarkus/maven/IncrementalBuildMojo.java
@@ -302,6 +302,15 @@ public class IncrementalBuildMojo extends AbstractMojo {
         Set<String> affectedTests = 
extractAffectedTests(report.affectedModules);
         affectedTests.addAll(containerModules.nativeModules);
 
+        if (affectedTests.isEmpty() && isBomDirectlyAffected(report)) {
+            getLog().info(
+                    "BOM directly affected but no test modules identified - 
falling back to full build for safety");
+            result.put("incrementalBuild", false);
+            result.put("modules", new ArrayList<>());
+            result.put("totalModules", 0);
+            return result;
+        }
+
         result.put("incrementalBuild", true);
         result.put("modules", new ArrayList<>(affectedTests));
         result.put("totalModules", affectedTests.size());
@@ -339,7 +348,7 @@ public class IncrementalBuildMojo extends AbstractMojo {
             // Handle regular integration-tests
             if (path != null && path.startsWith(nativeTestsPrefix)) {
                 // Include both DIRECT and DOWNSTREAM - if Scalpel detected 
it, test it
-                if ("DIRECT".equals(category) || 
"DOWNSTREAM".equals(category)) {
+                if ("DIRECT".equals(category) || "DOWNSTREAM".equals(category) 
|| "TRANSITIVE".equals(category)) {
                     // Extract test name: integration-tests/box -> box
                     String testName = 
path.substring(nativeTestsPrefix.length());
                     // Remove any trailing path components
@@ -355,6 +364,17 @@ public class IncrementalBuildMojo extends AbstractMojo {
         return affectedTests;
     }
 
+    private boolean isBomDirectlyAffected(ScalpelReport report) {
+        for (Map<String, Object> module : report.affectedModules) {
+            String path = (String) module.get("path");
+            String category = (String) module.get("category");
+            if (path != null && path.startsWith("poms/bom") && 
"DIRECT".equals(category)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     private static class ContainerAffectedModules {
         final Set<String> nativeModules = new LinkedHashSet<>();
         final Set<String> jvmModules = new LinkedHashSet<>();