gnodet commented on PR #24328: URL: https://github.com/apache/camel/pull/24328#issuecomment-4841407251
Thanks for the review @davsclaus! All three points addressed in the latest push: 1. **Footer hint** — Reverted to show current percentage (`splitIndex`), matching the zoom-indicator pattern. ✅ 2. **`System.err.println` → `LOG`** — Both calls in the static initializer and `getHistory()` now use `LOG.log(Level.WARNING, ...)`. ✅ 3. **Tests** — Added 5 new tests: `panelPercentDefaultIs50`, `cycleHeightCyclesThroughPercents` (verifies full 50→75→100→25→50 wrap), `renderFooterShowsCurrentPercentage`, `renderFooterUpdatesAfterCycleHeight`, and `renderFooterContainsExpectedHints`. All 265 module tests pass. ✅ Re: SLF4J vs `System.Logger` alignment with #24322 — happy to converge whichever direction the project prefers once both PRs land. _Claude Code on behalf of Guillaume Nodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
