davsclaus commented on code in PR #24358:
URL: https://github.com/apache/camel/pull/24358#discussion_r3505330784
##########
core/camel-core-reifier/src/main/java/org/apache/camel/reifier/ThreadsReifier.java:
##########
@@ -34,6 +34,8 @@ public ThreadsReifier(Route route, ProcessorDefinition<?>
definition) {
super(route, (ThreadsDefinition) definition);
}
+ // ExecutorService lifecycle is managed by ThreadsProcessor via
shutdownThreadPool flag
+ @SuppressWarnings("java:S2095")
Review Comment:
Same as AggregateReifier — this was narrowed to statement level in #22343
after explicit review feedback.
##########
core/camel-core-reifier/src/main/java/org/apache/camel/reifier/AggregateReifier.java:
##########
@@ -50,6 +50,8 @@ public Processor createProcessor() throws Exception {
return createAggregator();
}
+ // ExecutorService lifecycle is managed by AggregateProcessor via
shutdownThreadPool flag
+ @SuppressWarnings("java:S2095")
Review Comment:
This `@SuppressWarnings` was intentionally placed at the local variable
declaration level in PR #22343 after reviewer feedback from @squakez asked to
narrow the scope to avoid masking future real leaks in the same method. Moving
it back to method level reverses that decision.
If SonarCloud is not recognizing the statement-level annotation, that would
justify this change — could you confirm?
##########
components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponent.java:
##########
@@ -958,13 +958,14 @@ public RawClient createRawClientFor(SalesforceEndpoint
endpoint) throws Salesfor
return new DefaultRawClient(httpClient, "", session, loginConfig);
}
+ // ExecutorService lifecycle is managed by SalesforceHttpClient
+ @SuppressWarnings("java:S2095")
Review Comment:
The `// NOSONAR` inline comment was the accepted approach from PR #22343
review. Replacing it with method-level `@SuppressWarnings` widens the
suppression scope. Same question: is SonarCloud not picking up the `// NOSONAR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
