oscerd commented on PR #24348: URL: https://github.com/apache/camel/pull/24348#issuecomment-4854641153
Thanks for the review @davsclaus, and @apupier for flagging the conflict. Pushed 60093de addressing the feedback: **1. `bufferSize` dead code → removed.** Since authenticated encryption replaced the streaming implementation, the option no longer had any effect, so I removed it entirely — the field/getter/setter on the component and the `core-model` model (+ `Builder`), the hand-written reifier, and all regenerated metadata (configurer, catalog, XSD/YAML schemas, DSL writers/parsers). Documented in the component docs and the 4.22 upgrade guide. **2. `PQCSymmetricAlgorithms` retaining the "rejected" values → kept intentionally.** That enum is shared with the PQC *component* (the KEM operations in `PQCProducer`), not only the dataformat. `RC2`, `RC5`, `CAST5`, `GOST28147`, `DESEDE`, etc. are still valid there — they are used as key-derivation labels for `KEMGenerateSpec`/`KEMExtractSpec` and do not require AEAD (there are dedicated round-trip tests, e.g. `PQCMLKEMGenerateEncapsulationCryptoRoundTripDESedeTest`, `...GOST28147Test`, `...RC5Test`). Removing the entries would break the component. The dataformat instead restricts to the AEAD subset at runtime via `checkAeadSupported()`, and the dataformat's own DSL enum now lists only the 9 AEAD-capable algorithms. **3. Upgrade-guide memory-behavior note → added.** The 4.22 guide now mentions that payloads are processed in memory (the AEAD tag is verified before releasing plaintext) rather than streamed, and to enable stream caching for very large payloads. **Conflict** (@apupier): resolved by rebasing onto `main` (the concurrent 4_22 upgrade-guide addition for `camel-fory`); both entries are now in the guide and the PR is mergeable. The full-reactor build passes, and the stale `camel-spring.xsd` / `camel-xml-io.xsd` that were failing CI are regenerated. _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
