This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch feature/CAMEL-23870-heap-histogram in repository https://gitbox.apache.org/repos/asf/camel.git
commit 9756440d0195ce1f4e07f01bed857efda54edb0d Author: Claus Ibsen <[email protected]> AuthorDate: Wed Jul 1 16:10:59 2026 +0200 chore: use Locale.US consistently across TUI and CLI for number formatting Co-Authored-By: Claude <[email protected]> Signed-off-by: Claus Ibsen <[email protected]> --- .../org/apache/camel/impl/console/HeapHistogramDevConsole.java | 2 +- .../camel/dsl/jbang/core/commands/action/CamelHeapHistogram.java | 8 ++++---- .../apache/camel/dsl/jbang/core/commands/tui/FilesBrowser.java | 4 ++-- .../camel/dsl/jbang/core/commands/tui/HeapHistogramTab.java | 8 ++++---- .../org/apache/camel/dsl/jbang/core/commands/tui/McpFacade.java | 2 +- .../apache/camel/dsl/jbang/core/commands/tui/TapeRecorder.java | 8 ++++---- 6 files changed, 16 insertions(+), 16 deletions(-) diff --git a/core/camel-console/src/main/java/org/apache/camel/impl/console/HeapHistogramDevConsole.java b/core/camel-console/src/main/java/org/apache/camel/impl/console/HeapHistogramDevConsole.java index e07a5f0b1a97..80487b3d5ba9 100644 --- a/core/camel-console/src/main/java/org/apache/camel/impl/console/HeapHistogramDevConsole.java +++ b/core/camel-console/src/main/java/org/apache/camel/impl/console/HeapHistogramDevConsole.java @@ -128,7 +128,7 @@ public class HeapHistogramDevConsole extends AbstractDevConsole { String className = parts[3]; if (limit > 0 && count >= limit) { - break; + continue; } JsonObject jo = new JsonObject(); diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelHeapHistogram.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelHeapHistogram.java index 8636e4a4df22..4e5cf33b6e2f 100644 --- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelHeapHistogram.java +++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/CamelHeapHistogram.java @@ -216,16 +216,16 @@ public class CamelHeapHistogram extends ActionWatchCommand { if (bytes < 1024) { return bytes + " B"; } else if (bytes < 1024 * 1024) { - return String.format("%.1f KB", bytes / 1024.0); + return String.format(java.util.Locale.US, "%.1f KB", bytes / 1024.0); } else if (bytes < 1024L * 1024 * 1024) { - return String.format("%.1f MB", bytes / (1024.0 * 1024)); + return String.format(java.util.Locale.US, "%.1f MB", bytes / (1024.0 * 1024)); } else { - return String.format("%.1f GB", bytes / (1024.0 * 1024 * 1024)); + return String.format(java.util.Locale.US, "%.1f GB", bytes / (1024.0 * 1024 * 1024)); } } static String formatNumber(long num) { - return String.format("%,d", num); + return String.format(java.util.Locale.US, "%,d", num); } private static class Row { diff --git a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/FilesBrowser.java b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/FilesBrowser.java index adcfe23c7a30..51062724af1b 100644 --- a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/FilesBrowser.java +++ b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/FilesBrowser.java @@ -312,7 +312,7 @@ class FilesBrowser { static String fileType(Path path) { String name = path.getFileName().toString(); - String lower = name.toLowerCase(Locale.ROOT); + String lower = name.toLowerCase(Locale.US); if (lower.endsWith(".kamelet.yaml") || lower.endsWith(".kamelet.yml")) { return "camel"; } @@ -336,7 +336,7 @@ class FilesBrowser { private static String fileEmoji(Path path) { String name = path.getFileName().toString(); - String lower = name.toLowerCase(Locale.ROOT); + String lower = name.toLowerCase(Locale.US); if (lower.endsWith(".kamelet.yaml") || lower.endsWith(".kamelet.yml")) { return "🐪"; } diff --git a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HeapHistogramTab.java b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HeapHistogramTab.java index 3fe2004ce698..8af8db0cd01f 100644 --- a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HeapHistogramTab.java +++ b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HeapHistogramTab.java @@ -450,16 +450,16 @@ class HeapHistogramTab implements MonitorTab { if (bytes < 1024) { return bytes + " B"; } else if (bytes < 1024 * 1024) { - return String.format("%.1f KB", bytes / 1024.0); + return String.format(java.util.Locale.US, "%.1f KB", bytes / 1024.0); } else if (bytes < 1024L * 1024 * 1024) { - return String.format("%.1f MB", bytes / (1024.0 * 1024)); + return String.format(java.util.Locale.US, "%.1f MB", bytes / (1024.0 * 1024)); } else { - return String.format("%.1f GB", bytes / (1024.0 * 1024 * 1024)); + return String.format(java.util.Locale.US, "%.1f GB", bytes / (1024.0 * 1024 * 1024)); } } static String formatNumber(long num) { - return String.format("%,d", num); + return String.format(java.util.Locale.US, "%,d", num); } static class HeapEntry { diff --git a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/McpFacade.java b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/McpFacade.java index 66f6e776b248..dcf7e153c0d8 100644 --- a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/McpFacade.java +++ b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/McpFacade.java @@ -356,7 +356,7 @@ class McpFacade { KeyModifiers mods = KeyModifiers.of(ctrl, false, shift); - KeyCode code = switch (remainder.toLowerCase(Locale.ROOT)) { + KeyCode code = switch (remainder.toLowerCase(Locale.US)) { case "enter", "return" -> KeyCode.ENTER; case "esc", "escape" -> KeyCode.ESCAPE; case "tab" -> KeyCode.TAB; diff --git a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/TapeRecorder.java b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/TapeRecorder.java index 9fe3b138075a..b0b33dc3574e 100644 --- a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/TapeRecorder.java +++ b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/TapeRecorder.java @@ -170,7 +170,7 @@ class TapeRecorder { default -> null; }; } - String lower = key.toLowerCase(Locale.ROOT); + String lower = key.toLowerCase(Locale.US); if (lower.startsWith("ctrl+")) { return "Ctrl+" + key.substring(5); @@ -189,14 +189,14 @@ class TapeRecorder { } if (lower.matches("f\\d{1,2}")) { - return key.toUpperCase(Locale.ROOT); + return key.toUpperCase(Locale.US); } return null; } private static String capitalize(String s) { - return s.substring(0, 1).toUpperCase(Locale.ROOT) + s.substring(1); + return s.substring(0, 1).toUpperCase(Locale.US) + s.substring(1); } static String formatSleep(long ms) { @@ -205,7 +205,7 @@ class TapeRecorder { } if (ms >= 1000) { double seconds = ms / 1000.0; - String formatted = String.format(Locale.ROOT, "%.1f", seconds); + String formatted = String.format(Locale.US, "%.1f", seconds); return formatted + "s"; } long rounded = (ms / 100) * 100;
