gnodet commented on PR #24351: URL: https://github.com/apache/camel/pull/24351#issuecomment-4858680376
Thanks for the thorough review, Claus! Replying to the general notes: - **JIRA ticket** — will create one and update the commit messages. - **Tests** — fair point. The coordinate math in `findClickedTab`, `handleNodeClick`, `handleEipNodeClick`, and `setSplitPercent` is pure logic that can be unit-tested without a running TUI. Will add tests for the hit-testing and split math. - **HistoryTab and EIP node clicks** — intentional. HistoryTab shows topology-level diagrams (route overview) when in history mode, and uses `diagram.handleNodeClick()` for those. It doesn't drill into route-level EIP diagrams the way DiagramTab/ErrorsTab/RoutesTab do, so `handleEipNodeClick` isn't needed there. If we add EIP-level history views later, we'd add it then. Will address the inline comments (shared `MOUSE_SCROLL_LINES` constant, `setSplitPercent` extraction, navigate loop) in the next push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
