ammachado commented on PR #24365: URL: https://github.com/apache/camel/pull/24365#issuecomment-4860749703
Thanks for the review, @davsclaus. Follow-up in `1c5c030` addresses the two non-blocking observations: - **`MORE_ITEM_COUNT` staleness (#2)** — the dropdown entries are now built by a shared `moreItems()` helper, and both the constant (`MORE_ITEM_COUNT = moreItems().length`) and the popup height (`MORE_ITEM_COUNT + 2`) derive from it, so they can no longer drift when an entry is added or removed. - **Blank-line churn (#3)** — restored the incidental blank-line removals in `BrowseTab`, `HttpTab`, `ThreadsTab`, `SpansTab`, and `HistoryTab`. On observation #1 (the `PluginAdd.java` message): it is no longer part of this branch's diff against `main`, so there is nothing left to split out. Full `camel-jbang-plugin-tui` suite still green (516 tests). _Claude Code (Anthropic) on behalf of Adriano Machado_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
