davsclaus commented on code in PR #24337:
URL: https://github.com/apache/camel/pull/24337#discussion_r3510852533


##########
dsl/camel-jbang/camel-jbang-mcp/src/main/java/org/apache/camel/dsl/jbang/core/commands/mcp/RuntimeTools.java:
##########
@@ -292,11 +311,10 @@ public JsonObject camel_runtime_route_topology(
             @ToolArg(description = NAME_OR_PID_DESC) String nameOrPid,
             @ToolArg(description = "Include live metrics (message counts, 
throughput) on nodes and edges") Boolean metric,
             @ToolArg(description = "Include external systems (databases, 
messaging brokers, etc.) as nodes") Boolean external) {
-        RuntimeService.ProcessInfo p = 
runtimeService.findSingleProcess(nameOrPid);
-        return runtimeService.executeAction(p.pid(), "route-topology", root -> 
{
-            root.put("metric", metric != null && metric ? "true" : "false");
-            root.put("external", external != null && external ? "true" : 
"false");
-        });
+        Map<String, String> args = new HashMap<>();
+        args.put("metric", metric == null || metric ? "true" : "false");

Review Comment:
   okay that is good



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to