This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new cd6c8ddbe494 chore: print a confirmation when adding a camel-jbang
plugin (#24366)
cd6c8ddbe494 is described below
commit cd6c8ddbe494090b5aeea7235db53a5f8b42860b
Author: Adriano Machado <[email protected]>
AuthorDate: Thu Jul 2 03:09:35 2026 -0400
chore: print a confirmation when adding a camel-jbang plugin (#24366)
PluginAdd now prints a "Plugin <name> added" message so adding or upgrading
a
plugin gives visible feedback. This restores symmetry with PluginDelete,
which
already prints a "Plugin <name> removed" confirmation.
Co-authored-by: Claude Opus 4.8 <[email protected]>
---
.../apache/camel/dsl/jbang/core/commands/plugin/PluginAdd.java | 1 +
.../camel/dsl/jbang/core/commands/plugin/PluginAddTest.java | 10 +++++-----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/plugin/PluginAdd.java
b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/plugin/PluginAdd.java
index 4c1f4cc3d4b4..4b639c653e24 100644
---
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/plugin/PluginAdd.java
+++
b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/plugin/PluginAdd.java
@@ -160,6 +160,7 @@ public class PluginAdd extends PluginBaseCommand {
plugins.put(name, plugin);
saveConfig(pluginConfig);
+ printer().printf("Plugin %s added%n", name);
return 0;
}
diff --git
a/dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/commands/plugin/PluginAddTest.java
b/dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/commands/plugin/PluginAddTest.java
index e5e929556f43..b64b4d0d8296 100644
---
a/dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/commands/plugin/PluginAddTest.java
+++
b/dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/commands/plugin/PluginAddTest.java
@@ -41,7 +41,7 @@ class PluginAddTest extends CamelCommandBaseTestSupport {
command.name = "kubernetes";
command.doCall();
- Assertions.assertEquals("", printer.getOutput());
+ Assertions.assertEquals("Plugin kubernetes added",
printer.getOutput());
Assertions.assertEquals(
"{\"plugins\":{\"kubernetes\":{\"name\":\"kubernetes\",\"command\":\"kubernetes\",\"firstVersion\":\"4.8.0\",\"description\":\"%s\"}}}"
@@ -58,7 +58,7 @@ class PluginAddTest extends CamelCommandBaseTestSupport {
command.firstVersion = "1.2.3";
command.doCall();
- Assertions.assertEquals("", printer.getOutput());
+ Assertions.assertEquals("Plugin foo-plugin added",
printer.getOutput());
Assertions.assertEquals("{\"plugins\":{\"foo-plugin\":{\"name\":\"foo-plugin\",\"command\":\"foo\","
+
"\"firstVersion\":\"1.2.3\",\"description\":\"Some plugin\"}}}",
@@ -71,7 +71,7 @@ class PluginAddTest extends CamelCommandBaseTestSupport {
command.name = "foo";
command.doCall();
- Assertions.assertEquals("", printer.getOutput());
+ Assertions.assertEquals("Plugin foo added", printer.getOutput());
Assertions.assertEquals("{\"plugins\":{\"foo\":{\"name\":\"foo\",\"command\":\"foo\","
+
"\"description\":\"Plugin foo called with
command foo\"}}}",
@@ -86,7 +86,7 @@ class PluginAddTest extends CamelCommandBaseTestSupport {
command.gav = "org.apache.camel:foo-plugin:1.0.0";
command.doCall();
- Assertions.assertEquals("", printer.getOutput());
+ Assertions.assertEquals("Plugin foo-plugin added",
printer.getOutput());
Assertions.assertEquals("{\"plugins\":{\"foo-plugin\":{\"name\":\"foo-plugin\",\"command\":\"foo\","
+
"\"description\":\"Plugin foo-plugin called
with command foo\",\"dependency\":\"org.apache.camel:foo-plugin:1.0.0\"}}}",
@@ -103,7 +103,7 @@ class PluginAddTest extends CamelCommandBaseTestSupport {
command.version = "1.0.0";
command.doCall();
- Assertions.assertEquals("", printer.getOutput());
+ Assertions.assertEquals("Plugin foo-plugin added",
printer.getOutput());
Assertions.assertEquals("{\"plugins\":{\"foo-plugin\":{\"name\":\"foo-plugin\",\"command\":\"foo\","
+
"\"firstVersion\":\"1.0.0\",\"description\":\"Plugin foo-plugin called with
command foo\"" +