ammachado commented on PR #24386: URL: https://github.com/apache/camel/pull/24386#issuecomment-4878721964
Following up on @davsclaus's review, specifically the `InfraBaseCommand` observation: > **3. `InfraBaseCommand` still uses old pattern** — `InfraBaseCommand.java` (line 213-214) calls `flexWidth(...)` with hand-rolled fixed column widths but was not migrated to the new `CamelTableColumns` toolkit. This is fine as follow-up work, but if the contributor wants this PR to be the single source of truth for catalog-style tables, `InfraBaseCommand` follows the same pattern. `camel infra list` (`InfraBaseCommand`) is now migrated onto the toolkit (commit 3766f13). The infra table isn't quite the same shape as the catalog tables (its flex column was a middle column with `NEWLINE` wrapping, and it has two trailing unbounded columns), so the migration also made a small layout change: `DESCRIPTION` fills the terminal width, and `IMPLEMENTATION` / `SERVICE_DATA` truncate with an ellipsis instead of letting the raw JSON service data overflow the terminal. The full, structured service data remains available via `--json` (now covered by tests confirming it is embedded as nested JSON rather than an escaped string). One design question for reviewers before considering this settled: - **Does `SERVICE_DATA` belong in the table at all?** It currently renders raw JSON, which is not very readable in a terminal. Should the column be dropped from the table view (keeping the data available via `--json` only), or should it instead surface user-friendly, actionable information about the service, e.g. the port and credentials for a database? _Claude Code on behalf of Adriano Machado._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
