gnodet commented on PR #24447: URL: https://github.com/apache/camel/pull/24447#issuecomment-4891199444
_Claude Code on behalf of Guillaume Nodet_ ⚠️ **Concerns with this PR — please review before undrafting:** 1. **UDP pacing sleeps are valid**: The `Thread.sleep(100)` between UDP packet sends serves as intentional pacing to prevent packet loss. UDP is unreliable by nature — removing these sleeps could actually make the tests **more** flaky by flooding the receiver. These sleeps should be kept. 2. **Redundant Awaitility wrapping**: `MockEndpoint.assertIsSatisfied(context)` already waits on an internal `CountDownLatch` for up to 10 seconds by default. Wrapping it in `await().atMost(5, TimeUnit.SECONDS).untilAsserted(...)` is redundant and actually **reduces** the effective timeout from 10s to 5s. If more time is needed, use `mock.setResultWaitTime(millis)` instead. 3. **Flakiness not validated**: These tests were not confirmed flaky by running them 100+ times. The `Thread.sleep(100)` calls were flagged by static analysis, but they serve a purpose. **Recommendation**: Close this PR or revise it to only increase the `resultWaitTime` on the MockEndpoints if needed, while keeping the UDP pacing sleeps intact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
