gnodet commented on PR #24475: URL: https://github.com/apache/camel/pull/24475#issuecomment-4900410849
_Claude Code on behalf of gnodet_ @ammachado Thank you for the thorough review and the independent verification of the root cause against the `tamboui-css` source! All three suggestions addressed in commit 45396a7: 1. **Javadoc wording** (suggestion #1) — Fixed. Changed from "guaranteed to have access" to "in the normal Camel class-loading hierarchy has access to project resources. Falls back to the thread-context classloader when the primary lookup returns null." This makes the fallback path clearly intentional rather than dead code. 2. **`ConcurrentHashMap` → `HashMap`** (suggestion #2) — Reverted. You're right that every `CACHE` access is already inside a `synchronized` method, so the concurrent map added no real safety — just a misleading signal. Plain `HashMap` is correct here. 3. **TCCL fallback test gap** (suggestion #3) — Acknowledged. As you noted, properly testing this would require a custom classloader rig. The primary classloader path is exercised by all 6 existing tests, and the TCCL fallback is a defensive edge case (OSGi, bootstrap-loaded classes). Leaving as a known gap for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
