JiriOndrusek commented on code in PR #24405:
URL: https://github.com/apache/camel/pull/24405#discussion_r3534221980


##########
components/camel-ai/camel-weaviate/pom.xml:
##########
@@ -52,10 +52,12 @@
             <version>${langchain4j-version}</version>
         </dependency>
 
+        <!-- classifier=all is required: without it, gRPC's ServiceLoader 
breaks in fat JARs -->
         <dependency>
             <groupId>io.weaviate</groupId>
-            <artifactId>client</artifactId>
+            <artifactId>client6</artifactId>

Review Comment:
   Good question. I inspected the `client6-6.x-all.jar` — it bundles 
dependencies (Guava, Gson, HttpClient 5, commons-lang3, nimbus-jose-jwt) 
without relocation, but notably does NOT include gRPC or Netty classes. The 
gRPC dependency comes from the regular POM transitive chain. The full reactor 
build passes without classpath conflicts. Worth monitoring if future Camel 
components overlap on bundled versions, but no issues observed currently.
   
   _Claude Code on behalf of Jiri Ondrusek_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to