ammachado commented on PR #24545: URL: https://github.com/apache/camel/pull/24545#issuecomment-4921525513
Thanks for the review, @davsclaus. **On the #24541 dependency (item 1):** I've removed the `OrderedProperties.containsKey()` workaround in `TuiUserConfig.livesInLocal()`, which now calls `containsKey()` directly. This relies on the CAMEL-23971 fix from #24541, so this PR should land on top of / be rebased onto that change. I've dropped the explicit "Depends on #24541" line from the description now that the code references the fix directly, but the ordering still stands: #24541 first. A regression test (`writeUpdatesLocalForExistingLocalKeyWithEmptyValue`) covers the empty-valued-key case that `containsKey` handles but the old `getProperty` null-check did not. **On the folder precedence (inline comment):** fixed. `FolderInputPopup.open()` now checks `lastFolder` first, falling back to `defaultFolder` and then `user.dir`, matching the docs and PR description. Added `FolderInputPopupTest` with three cases covering the full precedence chain. **On `renamesLegacyLocalFileToNewName`:** the local config path resolves relative to the JVM working directory via `Paths.get(LOCAL_USER_CONFIG)`, and `CommandLineHelper` exposes no seam to redirect it (unlike home, which has `useHomeDir`), so the test must write to the real CWD by design. It already guards with `deleteIfExists` on both files before writing plus `try/finally` cleanup after. Happy to add a CWD-injection seam if you'd prefer stronger isolation. _Claude Code on behalf of Adriano Machado (ammachado)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
