gnodet commented on code in PR #24576:
URL: https://github.com/apache/camel/pull/24576#discussion_r3558250500
##########
components/camel-mail/src/test/java/org/apache/camel/component/mail/MailAttachmentsUmlautIssueTest.java:
##########
@@ -46,7 +46,7 @@
*/
@Disabled("Fails on CI servers and some platforms - maybe due locale or
something")
public class MailAttachmentsUmlautIssueTest extends CamelTestSupport {
- private static final MailboxUser james = Mailbox.getOrCreateUser("james",
"secret");
+ private static final MailboxUser james =
Mailbox.getOrCreateUser("MailAttachmentRedeliveryTest-james", "secret");
Review Comment:
Copy-paste bug: this uses `"MailAttachmentRedeliveryTest-james"` but the
class is `MailAttachmentsUmlautIssueTest`. Should be:
```suggestion
private static final MailboxUser james =
Mailbox.getOrCreateUser("MailAttachmentsUmlautIssueTest-james", "secret");
```
##########
components/camel-mail/src/test/java/org/apache/camel/component/mail/MailCollectionHeaderTest.java:
##########
@@ -30,7 +30,7 @@
import static org.junit.jupiter.api.Assertions.assertNotNull;
public class MailCollectionHeaderTest extends CamelTestSupport {
- private static final MailboxUser james = Mailbox.getOrCreateUser("james",
"secret");
+ private static final MailboxUser james =
Mailbox.getOrCreateUser("MailBatchConsumerTest-james", "secret");
Review Comment:
Copy-paste bug: this uses `"MailBatchConsumerTest-james"` but the class is
`MailCollectionHeaderTest`. This creates a mailbox collision with
`MailBatchConsumerTest`. Should be:
```suggestion
private static final MailboxUser james =
Mailbox.getOrCreateUser("MailCollectionHeaderTest-james", "secret");
```
##########
components/camel-mail/src/test/java/org/apache/camel/component/mail/MailToMultipleEndpointsTest.java:
##########
@@ -27,13 +27,13 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
public class MailToMultipleEndpointsTest extends CamelTestSupport {
- private static final MailboxUser james2 =
Mailbox.getOrCreateUser("james2", "secret");
- private static final MailboxUser james = Mailbox.getOrCreateUser("james",
"secret");
- private static final MailboxUser admin = Mailbox.getOrCreateUser("admin",
"secret");
+ private static final MailboxUser james2 =
Mailbox.getOrCreateUser("MailToMultipleEndpointsTestjames2", "secret");
Review Comment:
Nit: missing dash separator in all six usernames in this file. Every other
test class uses `ClassName-username` with a dash. Consider:
```suggestion
private static final MailboxUser james2 =
Mailbox.getOrCreateUser("MailToMultipleEndpointsTest-james2", "secret");
```
(Same for `james`, `admin`, `a`, `b`, `c` below.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
