This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
commit 4190d5c7d85acaa8f6e4b547e04bf6284877b1fd Author: Claus Ibsen <[email protected]> AuthorDate: Fri Jul 10 18:32:10 2026 +0200 chore: fix duplicate scrollbar and help text mismatches in MetricsTab, HttpTab, LogTab Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Claus Ibsen <[email protected]> --- .../camel/dsl/jbang/core/commands/tui/HttpTab.java | 2 +- .../camel/dsl/jbang/core/commands/tui/LogTab.java | 23 +++++++++++----------- .../dsl/jbang/core/commands/tui/MetricsTab.java | 13 +----------- 3 files changed, 14 insertions(+), 24 deletions(-) diff --git a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HttpTab.java b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HttpTab.java index d4ad4e60832f..b2117c1e134a 100644 --- a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HttpTab.java +++ b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/HttpTab.java @@ -1648,7 +1648,7 @@ class HttpTab extends AbstractTableTab { - **Response**: Shows the HTTP status code, response headers, and response body after sending - **History**: Recent requests you have sent, with the ability to replay any previous request - Press `Ctrl+S` to send the request. Press `p` to toggle pretty-print + Press `Enter` to send the request. Press `p` to toggle pretty-print for JSON responses — this formats the response body with indentation for easier reading. diff --git a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/LogTab.java b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/LogTab.java index 4d8385743588..0f919da3e7ac 100644 --- a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/LogTab.java +++ b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/LogTab.java @@ -740,19 +740,20 @@ class LogTab extends AbstractTab { 10:29:38 ERROR [Camel (camel-demo) thread #3] Connection refused: localhost:9092 ``` - ## Log Level Filter + ## Log Level - Press `l` to open the log level picker. Selecting a level filters the - display to show only messages at that level and above: + Press `l` to open the log level picker. Selecting a level changes the + running application's root logger to that level: - - Select **ERROR** — shows only ERROR messages - - Select **WARN** — shows WARN and ERROR - - Select **INFO** — shows INFO, WARN, and ERROR (default) - - Select **DEBUG** — shows everything except TRACE - - Select **TRACE** — shows all messages + - Select **ERROR** — only ERROR messages are logged + - Select **WARN** — WARN and ERROR are logged + - Select **INFO** — INFO, WARN, and ERROR are logged (default) + - Select **DEBUG** — everything except TRACE is logged + - Select **TRACE** — all messages are logged - Filtering is useful when the log is noisy with INFO messages and you - want to focus on warnings and errors. + This changes the actual log level of the running integration, not + just a display filter. It is useful for temporarily enabling debug + logging to diagnose an issue. ## Find and Highlight @@ -805,7 +806,7 @@ class LogTab extends AbstractTab { - `n` — next match - `N` — previous match - `h` — highlight a word - - `l` — change log level filter + - `l` — change log level - `f` — toggle follow mode - `w` — toggle word wrap - `Ctrl+L` — pin/cycle/unpin log panel (works from any tab) diff --git a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/MetricsTab.java b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/MetricsTab.java index 316421f5c93b..a2ee8cd1db6e 100644 --- a/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/MetricsTab.java +++ b/dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/MetricsTab.java @@ -64,7 +64,6 @@ class MetricsTab extends AbstractTableTab { private static final Style GOOD = Theme.success(); private static final Style BAD = Theme.error(); - private final ScrollbarState scrollbarState = new ScrollbarState(); private final ScrollbarState rawScrollbarState = new ScrollbarState(); private boolean tableMode; private int lastRowCount; @@ -519,16 +518,6 @@ class MetricsTab extends AbstractTableTab { lastTableArea = area; frame.renderStatefulWidget(table, area, tableState); renderScrollbar(frame, lastRowCount); - - int visibleRows = Math.max(1, area.height() - 4); - if (lastRowCount > visibleRows) { - Integer sel = tableState.selected(); - scrollbarState - .contentLength(lastRowCount) - .viewportContentLength(visibleRows) - .position(sel != null ? sel : 0); - frame.renderStatefulWidget(Scrollbar.builder().build(), area, scrollbarState); - } } // ---- Raw metrics view ---- @@ -1001,7 +990,7 @@ class MetricsTab extends AbstractTableTab { ## Keys - - `t` — toggle table mode + - `d` — toggle table mode - `r` — toggle raw Prometheus mode - `Up/Down` — navigate (in table or raw mode) - `s` — cycle sort column (in table mode)
