davsclaus commented on code in PR #1843:
URL:
https://github.com/apache/camel-spring-boot/pull/1843#discussion_r3560619016
##########
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##########
@@ -482,8 +482,8 @@ CamelBeanPostProcessor
camelBeanPostProcessor(ApplicationContext applicationCont
StartupConditionStrategy
startupConditionStrategy(CamelStartupConditionConfigurationProperties config) {
StartupConditionStrategy scs = new DefaultStartupConditionStrategy();
scs.setEnabled(config.isEnabled());
- scs.setInterval(config.getInterval());
- scs.setTimeout(config.getTimeout());
+ scs.setInterval((int) config.getInterval().toMillis());
+ scs.setTimeout((int) config.getTimeout().toMillis());
Review Comment:
Minor: `Duration.toMillis()` returns `long`; the `(int)` cast silently wraps
for large values. Consider using `Math.toIntExact()` to fail fast on
misconfiguration instead of silent overflow:
```suggestion
scs.setInterval(Math.toIntExact(config.getInterval().toMillis()));
scs.setTimeout(Math.toIntExact(config.getTimeout().toMillis()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
