davsclaus commented on PR #24690:
URL: https://github.com/apache/camel/pull/24690#issuecomment-4977225176
Thanks @gnodet for the thorough review! All four items have been addressed
in the latest commit:
1. **FQCN usage** — Fixed. Added `import java.util.Map` and changed the
parameter type to `Map<String, Object>`.
2. **Code duplication** — Fixed. Extracted a shared
`getSaslCallbackProperties()` helper method that returns the callback handler
properties as a `Map<String, String>`. Both `applySaslProperties()` (using
`putIfAbsent` to preserve user overrides) and `toProperties()` (using
`setProperty` on a fresh Properties) now delegate to this helper, eliminating
the duplicated switch blocks.
3. **Missing upgrade guide entry** — Added. Documented the OAuth JAAS string
format changes, the `putIfAbsent` semantics for explicit overrides, and the
Kerberos external JAAS configuration support in
`camel-4x-upgrade-guide-4_22.adoc`.
4. **Silent Kerberos behavior change** — Fixed. Added `LOG.debug("Kerberos
principal not set; assuming external JAAS configuration (e.g.
java.security.auth.login.config)")` before the early return.
_Claude Code on behalf of @davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
