davsclaus opened a new pull request, #24800:
URL: https://github.com/apache/camel/pull/24800

   ## Summary
   
   Fixes medium-severity findings from a review of the Circuit Breaker EIP in 
`camel-microprofile-fault-tolerance` 
([CAMEL-24136](https://issues.apache.org/jira/browse/CAMEL-24136)).
   
   - **M1+M2 — Exchange property contract**: `RESPONSE_TIMED_OUT` is now set in 
all timeout paths (with and without fallback). Guard exceptions (timeout, CB 
open) are now stored on the exchange before fallback invocation so the fallback 
can see them via `EXCEPTION_CAUGHT`. Removed ~20 lines of unreachable dead code 
from `CircuitBreakerFallbackTask`.
   - **Bulkhead enablement bug**: `FaultToleranceReifier.configureBulkhead()` 
never called `setBulkheadEnabled(true)` on the target config, so the bulkhead 
was never actually wired onto the `TypedGuard`. Fixed.
   - **M4 — Dead `timeoutPoolSize` option**: Deprecated across model, 
configuration, DSL, and JMX with `@Deprecated(since = "4.22.0")`. The option 
has been inert since the CAMEL-21857 TypedGuard migration.
   - **M3 (partial) — Misleading JMX description**: `getFailureRate()` 
description now says "configured failure ratio threshold" instead of "current 
failure rate in percentage" (it returns the static config value, not live 
metrics).
   - **M6 — Documentation errors**: Fixed incorrect timeout default claim in 
`circuitBreaker-eip.adoc`, wrong option names in `resilience4j-eip.adoc` and 
`fault-tolerance-eip.adoc`, incorrect no-fallback exception behavior 
description, and a misordered YAML example.
   - **Tests**: 2 new tests covering `RESPONSE_TIMED_OUT` and 
`EXCEPTION_CAUGHT` visibility in both no-fallback and with-fallback timeout 
scenarios. All 22 module tests pass.
   
   ## Test plan
   
   - [x] `mvn verify` passes in `camel-microprofile-fault-tolerance` (22 tests, 
0 failures)
   - [ ] CI green on all platforms
   - [ ] Verify existing circuit breaker tests in `camel-resilience4j` are 
unaffected
   
   _Claude Code on behalf of davsclaus_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   Co-Authored-By: Claude Opus 4.6 <[email protected]>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to