davsclaus commented on PR #24834: URL: https://github.com/apache/camel/pull/24834#issuecomment-5005681849
Thanks for the thorough review @oscerd! Both points are now addressed in the latest commit: 1. **Registry-bound saga service**: Good catch — `SagaDownloader` was using `main.bind()` which only puts the `InMemorySagaService` in the registry without lifecycle management. With `SagaProcessor.doStart()` removed, the service would never be started in the JBang/kamelet-main path. Fixed by switching to `context.addService(new InMemorySagaService())` with a guard against duplicate registration when multiple saga definitions exist. 2. **Constructor signature change**: The `SagaProcessor` subclass constructors are `public` but are only created through `SagaProcessorBuilder` — real-world impact is zero. Will add an upgrade guide note if needed. _Claude Code on behalf of Claus Ibsen_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
