davsclaus opened a new pull request, #24865:
URL: https://github.com/apache/camel/pull/24865

   ## Summary
   
   Fixes 5 medium-severity findings in camel-azure-servicebus from the July 
2026 code review 
([CAMEL-24159](https://issues.apache.org/jira/browse/CAMEL-24159)). This is PR 
1 of 5 (one per azure component).
   
   - **Credential override guard** — autowired `TokenCredential` no longer 
silently overrides an explicitly configured `credentialType` (regression from 
CAMEL-21871)
   - **Client leak on route restart** — internally-created 
`ServiceBusProcessorClient` is now properly closed in `doStop()`, preventing 
AMQP connection leaks on stop/start cycles
   - **User-provided client lifecycle** — user-provided (autowired) 
sender/processor clients are no longer closed by the component; only 
internally-created clients are managed
   - **CloudEvent content type** — fixed `containsKey()` (returns Boolean) to 
`getHeader()` (returns the actual content type string) in the CloudEvent 
transformer (bug since CAMEL-20450)
   - **APPLICATION_PROPERTIES mutation** — producer now defensive-copies the 
user-supplied `APPLICATION_PROPERTIES` map before adding propagated headers, 
preventing `UnsupportedOperationException` on immutable maps
   
   The 6th finding (maxConcurrentCalls backpressure for async routes) is a 
design limitation and will be addressed in a separate follow-up issue.
   
   ## Test plan
   
   - [x] Updated existing lifecycle tests to match new close/stop behavior
   - [x] Added `doStopStopsUserProvidedClientWithoutClosing` test
   - [x] Added `doShutdownDoesNotCloseUserProvidedClient` test
   - [x] `mvn clean install` passes (72 tests, 0 failures)
   
   _Claude Code on behalf of davsclaus_
   
   Co-Authored-By: Claude Opus 4.6 <[email protected]>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to