davsclaus opened a new pull request, #24869:
URL: https://github.com/apache/camel/pull/24869

   ## Summary
   
   _Claude Code on behalf of davsclaus_
   
   Fixes 5 medium-severity findings in `camel-azure-storage-blob` from 
CAMEL-24159 code review:
   
   - **Credential override guard** (`BlobComponent`): wrap the autowiring 
branch with `if (credentialType == null)` so user-explicit credential type is 
not overridden when a `TokenCredential` bean is found in the registry.
   - **changeFeed time bounds** (`BlobChangeFeedOperations`): change `||` to 
`&&` so that setting only `startTime` or only `endTime` correctly calls the 
time-bounded overload instead of discarding both.
   - **copyBlob validation** (`BlobOperations`): fix the second `isEmpty` check 
— it was re-checking `sourceAccountName` instead of `sourceContainerName`.
   - **ClassCastException with BlobRequestConditions** 
(`BlobCommonRequestOptions` + `BlobOperations`): remove the unsafe generic 
`(T)` cast from `getBlobRequestConditions()` that would throw 
ClassCastException at runtime when append/page blob operations need 
`AppendBlobRequestConditions` or `PageBlobRequestConditions`. Add proper 
type-safe conversion methods.
   - **Consumer fileDir download failures** (`BlobOperations`): create parent 
directories before downloading (fixes `NoSuchFileException` for nested blob 
names like `dir/file.txt`) and delete existing file first (fixes 
`FileAlreadyExistsException` on re-poll).
   
   ## Test plan
   
   - [x] Module builds successfully: `cd 
components/camel-azure/camel-azure-storage-blob && mvn clean install`
   - [ ] Verify credential override guard preserves user-explicit 
`credentialType=SHARED_KEY_CREDENTIAL`
   - [ ] Verify changeFeed with only startTime set returns bounded results
   - [ ] Verify copyBlob validates sourceContainerName is provided
   - [ ] Verify append/page blob operations with request conditions don't throw 
ClassCastException
   - [ ] Verify consumer re-poll downloads successfully without 
FileAlreadyExistsException
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   Co-Authored-By: Claude Opus 4.6 <[email protected]>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to