atiaomar1978-hub commented on PR #24880: URL: https://github.com/apache/camel/pull/24880#issuecomment-5008081179
Review feedback is applied, tests pass, and the branch is pushed. ## Changes Made | Suggestion | Action | |------------|--------| | **Upgrade guide** | Added `=== camel-openai` section to `camel-4x-upgrade-guide-4_22.adoc` documenting both behavior fixes | | **Property cleanup** | Added `exchange.removeProperty(PENDING_USER_MESSAGE)` at the start of `buildMessages()` | | **AssertJ tests** | Replaced JUnit assertions with AssertJ (`anyMatch`, `noneMatch`, `as(...)`) in both test classes | ## Tests Passed | Test | Result | |------|--------| | `OpenAIConversationMemoryUserMessageTest` | PASSED | | `OpenAIConversationMemoryResetTest` | PASSED | | `OpenAIProducerMcpMockTest#conversationMemoryIncludesToolCallChain` | PASSED | **Build:** `BUILD SUCCESS` — 3 tests, 0 failures ## Pushed - **Branch:** `CAMEL-23955-conversation-memory-fix` - **Commit:** `260c73a3871` — `CAMEL-23955: Address review feedback for conversation memory fix` - **Remote:** `https://github.com/atiaomar1978-hub/camel` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
