davsclaus opened a new pull request, #24885: URL: https://github.com/apache/camel/pull/24885
## Summary Fixes 9 bugs found during a deep code review of camel-salesforce: - **JsonRestProcessor**: fix infinite loop on non-object JSON in deferred SObject type detection (`while` loop never terminates on arrays/primitives), and fix `RuntimeException` escaping `IOException` catch block causing silent data corruption - **DefaultBulkApiV2Client**: add missing `return` after error callback in `changeJobState`/`changeQueryJobState` to prevent double callback execution - **SalesforceEndpointConfig**: add `allOrNone` to `toValueMap()` so the URI option actually takes effect, and fix `REPLAY_PRESET` mapped to wrong field (`initialReplayIdMap` instead of `replayPreset`) - **PubSubApiClient**: skip binary trailer keys in `onError` to prevent `IllegalArgumentException` killing reconnection, add stop/channel checks in `resubscribeOnError` to prevent infinite loop on shutdown, cap reconnect delay at `maxBackoff`, and restore thread interrupt flag - **SubscriptionHelper**: add backoff delay to handshake retry to prevent tight retry loop hammering the Salesforce API - **SalesforceSecurityHandler**: guard against null `client` in 401 handling to prevent NPE for CometD streaming requests - **SalesforceSession**: make latch `volatile` and remove dead spin loop to fix race condition in `attemptLoginUntilSuccessful` ## Test plan - [ ] Verify `mvn install` passes for `camel-salesforce-component` - [ ] Review each fix individually for correctness - [ ] Verify no API/behavioral regressions _Claude Code on behalf of davsclaus_ Co-Authored-By: Claude Opus 4.6 <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
