atiaomar1978-hub commented on PR #24903:
URL: https://github.com/apache/camel/pull/24903#issuecomment-5014163767
**Last change summary** — commit `0905a931b031` on
`CAMEL-24198-eventhubs-per-partition-checkpoint-batching`
### What changed
Review feedback on the per-partition checkpoint batching work:
**1. `EventHubsConsumer.java`**
- In `doStop()`, clear all three per-partition maps:
- `processedEventsByPartition`
- `scheduledTasksByPartition`
- `checkpointTasksByPartition`
- Avoids leaving partition state around after the consumer stops (partition
count is small, but this keeps cleanup explicit).
**2. `EventHubsConsumerPerPartitionCheckpointTest.java`**
- Switched assertions from JUnit to **AssertJ**
(`assertThat(...).isEqualTo()`, `.isZero()`, `.hasSize()`, `.isEmpty()`,
`.isNotSameAs()`).
- Added **`doStopClearsPerPartitionCheckpointState`** to verify all maps are
empty after `doStop()`.
**3. `pom.xml`**
- Added **`assertj-core`** (test scope), aligned with other Azure components
like `camel-azure-servicebus`.
### Verification
- **20/20** EventHubs tests passed
- **Pushed** to
`origin/CAMEL-24198-eventhubs-per-partition-checkpoint-batching`
### Branch history
| Commit | Description |
|--------|-------------|
| `8896d7755582` | Initial per-partition checkpoint batching fix |
| `0905a931b031` | Review follow-up (cleanup + AssertJ + new test) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
