oscerd opened a new pull request, #24958:
URL: https://github.com/apache/camel/pull/24958

   ### Motivation
   
   [CAMEL-23562](https://issues.apache.org/jira/browse/CAMEL-23562): upgrade 
Smack to the 4.4.x line (4.4.8 is the latest stable on Maven Central; 4.5 is 
still in beta). We were on 4.3.5, released in 2019.
   
   ### Changes
   
   - `smack-version` 4.3.5 → 4.4.8; `smack-java7` (gone in 4.4) replaced by 
`smack-java8` in the camel-xmpp pom.
   - `XmppBinding`: `DefaultExtensionElement` was removed in Smack 4.4 — the 
fallback branch for an unparsed JiveProperties extension now uses its 
replacement `StandardExtensionElement`, mapping flat child elements to headers 
with the same header-filter application as before. (The primary 
`JivePropertiesExtension` path is unchanged.)
   - `XmppLogger`: `stanza.toXML(null)` is ambiguous against the 4.4 `Element` 
overloads (`toXML(XmlEnvironment)` vs `toXML(String)`) — switched to the no-arg 
`toXML()`.
   - Upgrade-guide entry (4.22) noting the upgrade, the module rename, and 
linking the Smack 4.4 readme for library-level behavioral changes.
   
   ### Testing
   
   - Unit tests: all pass.
   - The module's container-based integration tests (`*IT`, XMPP server via 
test-infra) fail in my environment with `SSLHandshakeException: Remote host 
terminated the handshake` — **identically on current main with Smack 4.3.5** 
(verified by running the baseline first: same 1 failure + 6 errors, same 
exception). So their outcome is unchanged by this upgrade; the pre-existing 
test-server TLS issue can be looked at separately.
   - Full reactor `mvn clean install -DskipTests` from root: success, no stale 
generated files.
   
   No backport: dependency upgrade, main/4.22.0 only.
   
   _Claude Code on behalf of Andrea Cosentino (@oscerd)._
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to