davsclaus opened a new pull request, #24960:
URL: https://github.com/apache/camel/pull/24960

   ## Summary
   
   _Claude Code on behalf of davsclaus_
   
   - Fix non-deterministic property ordering in generated model writers 
(`YamlModelWriter`, `ModelWriter`, `JavaDslModelWriter`) for `*Common` base 
classes (`Resilience4jConfigurationCommon`, `FaultToleranceConfigurationCommon`)
   - The code generator (`ModelWriterGeneratorMojo`) sorts `doWriteAttribute` 
calls by JSON metadata `index`, but model lookup used the exact class name — 
`*Common` classes have no model entry (registered under `*Definition`), so 
sorting was skipped and property order depended on JDK reflection order
   - Add fallback: when no model is found and class name ends with `Common`, 
retry with `Definition` suffix
   
   This fixes the `YamlModelWriterTest.testCircuitBreaker` failure on JDK 25 in 
PR #24957, where `minimumNumberOfCalls` appeared before `failureRateThreshold` 
due to different reflection ordering.
   
   ## Test plan
   
   - [x] `YamlModelWriterTest.testCircuitBreaker` passes (was failing on JDK 25)
   - [x] Full `camel-yaml-io` test suite passes (148 tests)
   - [x] Generated writers for all three DSLs (YAML, XML, Java) now follow JSON 
metadata index order
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   Co-Authored-By: Claude Opus 4.6 <[email protected]>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to