atiaomar1978-hub commented on PR #24997: URL: https://github.com/apache/camel/pull/24997#issuecomment-5048466102
@oscerd @davsclaus @gnodet — this is ready for re-review. All review feedback has been addressed: - **@oscerd's blocking concern (guard keyed off the wrong signal):** the component-flag guard has been fully removed. `HttpProducer.java` is now byte-for-byte identical to `main` (`git diff main -- HttpProducer.java` is empty), so the decompression decision comes purely from `entity.getContentEncoding()` — what the client actually did — and the three endpoint-level disable paths (`?httpClient.contentCompressionEnabled=false`, a `httpClientConfigurer` calling `disableContentCompression()`, and a user-supplied client) can no longer be misread into silent data corruption. - **@gnodet's inline comments (wrong signal + dead code path):** both resolved by the revert above — the guard and the unreachable response-header fallback are gone. - **Prior-fix acknowledgement:** the description now explicitly credits `4a903e2b8f3c` as the commit that already fixed the production bug on `main`. - **Tests documenting vs protecting:** confirmed — the assertions pass against unmodified `HttpProducer.java`. The PR is now scoped as **regression coverage only, no production change**. - **Duplication:** the standalone `HttpProducerGzipAutoDecompressionTest` (~90 lines) was removed; coverage is consolidated into `HttpCompressionTest`, including a new `compressedHttpPostWithEndpointContentCompressionDisabled` test for the exact config the reverted guard would have corrupted. - **Upgrade guide / `@TestMethodOrder`:** not needed — no behaviour change, and the ordering annotations are gone. `mvn test -pl components/camel-http -Dtest=HttpCompressionTest` → 3 tests, all green. Separately, @gnodet raised that the reporter is on 4.18.x — happy to open a targeted backport of `4a903e2b8f3c` to `camel-4.18.x` as a follow-up if that's the preferred path. _Claude Opus 4.8 on behalf of atiaomar1978-hub_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
