davsclaus commented on code in PR #25035:
URL: https://github.com/apache/camel/pull/25035#discussion_r3636535501


##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ExportCamelMain.java:
##########
@@ -292,6 +292,7 @@ protected Set<String> resolveDependencies(Path settings, 
Path profile) throws Ex
         answer.removeIf(s -> s.contains("camel-core"));
         answer.removeIf(s -> s.contains("camel-main"));
         answer.removeIf(s -> s.contains("camel-health"));
+        answer.removeIf(s -> s.contains("camel-micrometer-prometheus"));

Review Comment:
   _Claude Code on behalf of davsclaus_
   
   Fixed. Switched both `camel-micrometer-prometheus` (line 305) and 
`camel-health` (line 309) to `camel:` shorthand format, and removed the 
`removeIf` line. The `Set` naturally deduplicates the identical string the base 
class already adds. Added a test (`shouldNotDuplicateMetricsDependency`) that 
verifies no duplicate entry in the exported pom.xml.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to