oscerd commented on PR #25048: URL: https://github.com/apache/camel/pull/25048#issuecomment-5058020076
Thank you for the thorough review — all findings were valid and have been addressed in the latest push: **High Severity (all fixed):** 1. ✅ Removed fabricated `CamelAwsBedrockModelId` header — `modelId` is now an endpoint parameter on the `aws-bedrock:` URI 2. ✅ Removed fabricated `CamelAwsBedrockInputType` header 3. ✅ Added required `modelId` endpoint parameter to all generated Bedrock endpoints 4. ✅ Fixed Docling parameter: `serverUrl` → `doclingServeUrl` 5. ✅ Added missing `useDoclingServe: true` flag **Medium Severity (fixed):** 6. ✅ Fixed default model ID prefix: `us.anthropic.` → `anthropic.` (matching `BedrockModels.ANTROPHIC_CLAUDE_SONNET_V4`) **Low Severity (fixed):** 8. ✅ `ScaffoldResult` record is now `public record` 9. ✅ Tests now assert correct parameter names (`modelId:`, `doclingServeUrl:`, `useDoclingServe: true`) and verify fabricated headers are absent **Not addressed (acknowledged):** 7. CatalogService validation — valid concern. The tool hardcodes parameter names rather than looking them up from the catalog. Adding catalog-based validation is a good follow-up but would significantly change the tool's approach. Filed as a note for future improvement. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
