ammachado commented on PR #25072:
URL: https://github.com/apache/camel/pull/25072#issuecomment-5070597007
@davsclaus all three issues from your review are fixed in c4b2da24d7e5:
1. `camel-publish.sh` now dot-sources `publish-state.sh` instead of running
it as a subprocess.
2. The JReleaser override hook no longer uses bash indirect expansion
(`${!hook}`) — checks `${CAMEL_PUB_JRELEASER:-}` directly.
3. `publish-state.sh` no longer uses `$'\n'` (bash ANSI-C quoting) — uses a
literal-newline variable instead.
All three verified to parse and run correctly under `dash` (strict POSIX
sh), not just macOS's bash-as-`/bin/sh`.
While in there, also fixed a few related bugs in `camel-publish.sh` found
during the same pass: a broken `$(_operator)` command substitution that should
have been `$_operator`, three PR-body attribution lines that were single-quoted
and never expanded, and a dead/broken override block in `__dest_website`
(replaced with the same `${FORK_REMOTE:-upstream}` pattern already used by
`__dest_winget`/`__dest_scoop`). Replied inline on each of your three threads
with specifics.
Separately, `install.sh` now uses `wget -nv` instead of `-q` (so failures
print wget's own diagnostic, matching curl's `-fsSL`/`-S` behavior), and tar
archive validation surfaces tar's actual error message instead of a generic
"not a valid tar.gz".
Re-requesting your review — let me know if anything still looks off.
_Claude Code on behalf of ammachado_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
